Created attachment 57397 [details] [review] Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings This patch makes t/db_dependent/Patron/Borrower_Discharge.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Patron/Borrower_Discharge.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions
No errors for me without patch (master commit 80c80ca683217455221e15e0c24a81d5e60e49e0) t/db_dependent/Patron/Borrower_Discharge.t .. ok All tests successful. Files=1, Tests=18, 3 wallclock secs ( 0.02 usr 0.00 sys + 1.89 cusr 0.11 csys = 2.02 CPU) Result: PASS
(In reply to Bernardo Gonzalez Kriegel from comment #2) > No errors for me without patch > (master commit 80c80ca683217455221e15e0c24a81d5e60e49e0) > > t/db_dependent/Patron/Borrower_Discharge.t .. ok > All tests successful. > Files=1, Tests=18, 3 wallclock secs ( 0.02 usr 0.00 sys + 1.89 cusr 0.11 > csys = 2.02 CPU) > Result: PASS Don't you get warnings? This is what I get: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_Discharge.t .. item-level_itypes set but no itemtype set for item (1291) at /home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 698. t/db_dependent/Patron/Borrower_Discharge.t .. 1/18 item-level_itypes set but no itemtype set for item (1291) at /home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 698. t/db_dependent/Patron/Borrower_Discharge.t .. ok All tests successful. Files=1, Tests=18, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.72 cusr 0.26 csys = 2.01 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
Created attachment 57434 [details] [review] [SIGNED-OFF]Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings This patch makes t/db_dependent/Patron/Borrower_Discharge.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Patron/Borrower_Discharge.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Created attachment 57441 [details] [review] Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings This patch makes t/db_dependent/Patron/Borrower_Discharge.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Patron/Borrower_Discharge.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 16.11, thanks Tomas!
Pushed to 16.05.x, for 16.05.06 release