When creating an aqorder for a quote orderline currency is not explicitly set. The process should set it to the appropriate currency for the vendor
Created attachment 57421 [details] [review] Proposed patch Without the patch currency in created orders defaults to null - with patch they are set to the currency as specified in the vendor record for listprice
Created attachment 57811 [details] [review] Bug 17605 Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Signed off
Note that we have a Koha::Object for Bookseller(s)
(In reply to Marcel de Rooy from comment #4) > Note that we have a Koha::Object for Bookseller(s) By not using the Koha::Object this patch will apply to the stable banches 16.5 and 16.11 Booksellers.pm and hence the find method only present in master
(In reply to Colin Campbell from comment #5) > (In reply to Marcel de Rooy from comment #4) > > Note that we have a Koha::Object for Bookseller(s) > > By not using the Koha::Object this patch will apply to the stable banches > 16.5 and 16.11 Booksellers.pm and hence the find method only present in > master Agreed. Sounds reasonable for the stable branches. Since the patch only deals with two lines, you could also supply two versions?
Created attachment 61027 [details] [review] Patch against master Previous version of patch required for 16.5 or 16.11 this version wraps the dbic calls in Koha::Object::Booksellers but requires dependencies currently only im master
(In reply to Marcel de Rooy from comment #6) > (In reply to Colin Campbell from comment #5) > > (In reply to Marcel de Rooy from comment #4) > > > Note that we have a Koha::Object for Bookseller(s) > > > > By not using the Koha::Object this patch will apply to the stable banches > > 16.5 and 16.11 Booksellers.pm and hence the find method only present in > > master > > Agreed. Sounds reasonable for the stable branches. > Since the patch only deals with two lines, you could also supply two > versions? Done
They are exactly the same?
Created attachment 61028 [details] [review] Patch against master oops uploaded wrong version - corrected
Created attachment 61029 [details] [review] Bug 17605: [MASTER] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 61030 [details] [review] Bug 17605: [STABLE] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Changing enhancement to normal. Stable patch is provided for stable branches.. Looks good to me. Just noting for the record that we do not have unit tests for Koha::EDI. Should not block this twoliner.. Passed QA
Pushed the MASTER one to master. should be in 17.05 ;) Thanks Note we still have a STABLE on to take care of
Pushed the [STABLE] patch. This patch has been pushed to 16.11.x and will be in 16.11.06.
Pushed to 16.05.x, for 16.05.12 release