Created attachment 57515 [details] [review] Bug 17636: Remove itemtype-related GetIssues.t warnings This patch makes t/db_dependent/Circulation/GetIssues.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/GetIssues.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetIssues.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions
Created attachment 57554 [details] [review] [SIGNED-OFF]Bug 17636: Remove itemtype-related GetIssues.t warnings This patch makes t/db_dependent/Circulation/GetIssues.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/GetIssues.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetIssues.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly
Created attachment 57599 [details] [review] [PASSED QA] Bug 17636: Remove itemtype-related GetIssues.t warnings This patch makes t/db_dependent/Circulation/GetIssues.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/GetIssues.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetIssues.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 16.11, thanks Tomas!
Pushed to 16.05.x, for 16.05.06 release