17647 – Remove itemtype-related CancelReceipt.t warnings

Bug 17647 - Remove itemtype-related CancelReceipt.t warnings

Summary: Remove itemtype-related CancelReceipt.t warnings

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Test Suite (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Tomás Cohen Arazi (tcohen)
QA Contact:	Kyle M Hall (khall)

URL:
Keywords:

Depends on:	14598
Blocks:
	Show dependency tree / graph

Reported:	2016-11-16 19:44 UTC by Tomás Cohen Arazi (tcohen)
Modified:	2018-06-04 20:09 UTC (History)
CC List:	1 user (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 17647: Remove itemtype-related CancelReceipt.t warnings (3.17 KB, patch) 2016-11-16 19:46 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Bug 17647: Remove itemtype-related CancelReceipt.t warnings (3.23 KB, patch) 2016-11-17 09:11 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
[PASSED QA] Bug 17647: Remove itemtype-related CancelReceipt.t warnings (3.30 KB, patch) 2016-11-18 07:12 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomás Cohen Arazi (tcohen) 2016-11-16 19:44:14 UTC

Comment 1 Tomás Cohen Arazi (tcohen) 2016-11-16 19:46:31 UTC

Created attachment 57576 [details] [review]
Bug 17647: Remove itemtype-related CancelReceipt.t warnings

This patch makes t/db_dependent/Acquisition/CancelReceipt.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Acquisition/CancelReceipt.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Acquisition/CancelReceipt.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Sponsored-by: ByWater Solutions

Comment 2 Jonathan Druart 2016-11-17 09:11:31 UTC

Created attachment 57591 [details] [review]
Bug 17647: Remove itemtype-related CancelReceipt.t warnings

This patch makes t/db_dependent/Acquisition/CancelReceipt.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Acquisition/CancelReceipt.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Acquisition/CancelReceipt.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 3 Katrin Fischer 2016-11-18 07:12:10 UTC

Created attachment 57613 [details] [review]
[PASSED QA] Bug 17647: Remove itemtype-related CancelReceipt.t warnings

This patch makes t/db_dependent/Acquisition/CancelReceipt.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Acquisition/CancelReceipt.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Acquisition/CancelReceipt.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>

Comment 4 Kyle M Hall (khall) 2016-11-18 14:01:20 UTC

Pushed to master for 16.11, thanks Tomas!

Comment 5 Mason James 2016-12-14 11:23:36 UTC

Pushed to 16.05.x, for 16.05.06 release