[Thu Nov 17 14:16:50 2016] [debug] GET "/api/v1/patrons" [Thu Nov 17 14:16:50 2016] [debug] Routing to a callback [Thu Nov 17 14:16:50 2016] [debug] Nothing has been rendered, expecting delayed response [Thu Nov 17 14:16:50 2016] [debug] Swagger2 routing to controller "Koha::REST::V1::Patron" and action "list" [Thu Nov 17 14:16:50 2016] [debug] 500 Internal Server Error (0.121564s, 8.226/s) ok 15 - GET /api/v1/patrons not ok 16 - 200 # Failed test '200 OK' # at t/db_dependent/api/v1/patrons.t line 122. # got: '500' # expected: '200'
If borrowers.updated_on is null, the tests will fail
Created attachment 57604 [details] [review] Bug 17651: borrowers.updated_on can be null - swagger def The swagger file does not consider borrowers.updated_on as a nullable value, it should Test plan: 0/ Do not apply this patch 1/ update borrowers set updated_on=null; 2/ prove t/db_dependent/api/v1/patrons.t => Fail 3/ Apply this patch 4/ prove t/db_dependent/api/v1/patrons.t => green
Created attachment 57607 [details] [review] Bug 17651: borrowers.updated_on can be null - swagger def The swagger file does not consider borrowers.updated_on as a nullable value, it should Test plan: 0/ Do not apply this patch 1/ update borrowers set updated_on=null; 2/ prove t/db_dependent/api/v1/patrons.t => Fail 3/ Apply this patch 4/ prove t/db_dependent/api/v1/patrons.t => green Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Trivial tests fix, passing QA.
Pushed to master for 16.11, thanks Jonathan!