Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :)
Created attachment 57662 [details] [review] Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [2] Check if you see Tools/Upload (with sufficient perms).
Created attachment 57664 [details] [review] [SIGNED OFF] Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [2] Check if you see Tools/Upload (with sufficient perms). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #2) > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Great!
Created attachment 57675 [details] [review] Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [3] Check if you see Tools/Upload (with sufficient perms).
Created attachment 57676 [details] [review] Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [3] Check if you see Tools/Upload (with sufficient perms). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 57677 [details] [review] Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [3] Check if you see Tools/Upload (with sufficient perms). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Has been pushed by Kyle on November 21, 2016. Thanks.
Pushed to 16.05.x, will be in 16.05.06