If a record has any holds on it, the SIP2 item information response will return a value of 08 "waiting on hold shelf" even if the item is not actually a waiting hold. This is clearly a bug.
Created attachment 57687 [details] [review] Bug 17665 - SIP2 Item Information Response returns incorrect circulation status of '08' ( waiting on hold shelf ) if record has any holds If a record has any holds on it, the SIP2 item information response will return a value of 08 "waiting on hold shelf" even if the item is not actually a waiting hold. This is clearly a bug. Test Plan: 1) Find an item that is not a waiting hold, but whose record has one or more holds. 2) Issue a SIP2 item information request 3) Note in the response, the circulation status field is '08' 4) Apply this patch 5) Repeat the item informationr request 6) Note the code is now '03' ( available ) 7) Check the item in to fill the hold 8) Repeat the item information request 9) Verify the circulation status is now '08'
Hi Kyle, as you are looking into this - what's the best option to recognize an item that needs to go on the hold shelf via SIP2? (for sorting etc.) Item request after checkin? Or is there another way to do it?
Created attachment 57703 [details] [review] Bug 17665 - SIP2 Item Information Response returns incorrect circulation status of '08' ( waiting on hold shelf ) if record has any holds If a record has any holds on it, the SIP2 item information response will return a value of 08 "waiting on hold shelf" even if the item is not actually a waiting hold. This is clearly a bug. Test Plan: 1) Find an item that is not a waiting hold, but whose record has one or more holds. 2) Issue a SIP2 item information request 3) Note in the response, the circulation status field is '08' 4) Apply this patch 5) Repeat the item informationr request 6) Note the code is now '03' ( available ) 7) Check the item in to fill the hold 8) Repeat the item information request 9) Verify the circulation status is now '08'
Created attachment 62059 [details] [review] Bug 17665 - SIP2 Item Information Response returns incorrect circulation status of '08' ( waiting on hold shelf ) if record has any holds If a record has any holds on it, the SIP2 item information response will return a value of 08 "waiting on hold shelf" even if the item is not actually a waiting hold. This is clearly a bug. Test Plan: 1) Find an item that is not a waiting hold, but whose record has one or more holds. 2) Issue a SIP2 item information request 3) Note in the response, the circulation status field is '08' 4) Apply this patch 5) Repeat the item informationr request 6) Note the code is now '03' ( available ) 7) Check the item in to fill the hold 8) Repeat the item information request 9) Verify the circulation status is now '08' Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch>
QA: Looking here now
Created attachment 63562 [details] [review] Bug 17665 - SIP2 Item Information Response returns incorrect circulation status of '08' ( waiting on hold shelf ) if record has any holds If a record has any holds on it, the SIP2 item information response will return a value of 08 "waiting on hold shelf" even if the item is not actually a waiting hold. This is clearly a bug. Test Plan: 1) Find an item that is not a waiting hold, but whose record has one or more holds. 2) Issue a SIP2 item information request 3) Note in the response, the circulation status field is '08' 4) Apply this patch 5) Repeat the item informationr request 6) Note the code is now '03' ( available ) 7) Check the item in to fill the hold 8) Repeat the item information request 9) Verify the circulation status is now '08' Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05!
I am not sure, but was wondering if some 'self returns' might use that to recognize items on hold for sorting them accordingly. Is this something to worry about?
(In reply to Katrin Fischer from comment #8) > I am not sure, but was wondering if some 'self returns' might use that to > recognize items on hold for sorting them accordingly. Is this something to > worry about? Most I'm familiar with use the checkin response to govern sorting so (hopefully) this should not affect the workflow
Hi Colin, thx for commenting. Because I've been trying to figure this out - which is the marker in the return response?
(In reply to Katrin Fischer from comment #10) > Hi Colin, thx for commenting. Because I've been trying to figure this out - > which is the marker in the return response? 3M added a number of hold related fields CY id of the user with the hold, CT location to route to DA Hold Patron name and CV Alert Type which is 01 if a hold is found 02 if a hold is found requiring transit.
Ok, will take me a bit to decipher this :) But this is what Koha does now or just how the standard describes it?