Around line 38 of the template file a sentence is missing a period: <p>Please fill out this form to make a purchase suggestion. You will receive an email when the library processes your suggestion</p> In an attempt to make this patch more worthwhile, I went looking for other typos in the template and found another missing period around line 259 in the conditional text that appears if the user has more pending suggestions than the MaxOpenSuggestions setting allows: <p class="TooManySuggestionsText">You have reached your limit of suggestions you can place at this time.</br>Once the library has processed those suggestions you will be able to place more</p> Testing plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Patch coming shortly.
Created attachment 57809 [details] [review] patch
Created attachment 57812 [details] [review] Bug 17696: missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph
Created attachment 57814 [details] [review] Attachment to Bug 17696 - Two missing periods in opac-suggestions.tt Bug 17696: missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> HEAD detached from origin/master Changes to be committed: modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
Created attachment 57831 [details] [review] Bug 17696: Add 2 missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Eric!
(In reply to Kyle M Hall from comment #5) > Pushed to master for 16.11, thanks Eric! 16.11 or 17.05 ?
This patch has been pushed to 16.11.x, will be in 16.11.01.