17715 – Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings

Bug 17715 - Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings

Summary: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Test Suite (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Tomás Cohen Arazi (tcohen)
QA Contact:	Galen Charlton

URL:
Keywords:

Depends on:
Blocks:

Reported:	2016-12-02 17:32 UTC by Tomás Cohen Arazi (tcohen)
Modified:	2018-06-04 20:10 UTC (History)
CC List:	1 user (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings (3.84 KB, patch) 2016-12-02 17:33 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings (3.90 KB, patch) 2016-12-02 18:49 UTC, Mark Tompsett	Details \| Diff \| Splinter Review
Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings (3.95 KB, patch) 2016-12-05 13:22 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomás Cohen Arazi (tcohen) 2016-12-02 17:32:04 UTC

Comment 1 Tomás Cohen Arazi (tcohen) 2016-12-02 17:33:52 UTC

Created attachment 57937 [details] [review]
Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings

This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Comment 2 Mark Tompsett 2016-12-02 18:49:35 UTC

Created attachment 57940 [details] [review]
[SIGNED-OFF] Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings

This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Comment 3 Jonathan Druart 2016-12-05 13:22:01 UTC

Created attachment 57959 [details] [review]
Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings

This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Holds/RevertWaitingStatus.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 4 Kyle M Hall (khall) 2016-12-05 15:32:10 UTC

Pushed to master for 17.05, thanks Tomas!

Comment 5 Katrin Fischer 2016-12-05 20:29:21 UTC

This patch has been pushed to 16.11.x, will be in 16.11.01.