To replicate: Make sure you have at least one lost item in your result set Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included You will probably get an error: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091.
Created attachment 58182 [details] [review] Bug 17764: (bug 17556 follow-up) Fix search for logged out users and lost items If you are non logged-in and you the search result contain lost items, you will get: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. This is because bug 17556 assumed that $userenv was not defined when the user is logged out. Actually it is, with non defined or empty string values. Test plan: Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included. => Without this patch you should get an error => With this patch applied you should see the search results
Created attachment 58188 [details] [review] [SIGNED-OFF] Bug 17764: (bug 17556 follow-up) Fix search for logged out users and lost items If you are non logged-in and you the search result contain lost items, you will get: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. This is because bug 17556 assumed that $userenv was not defined when the user is logged out. Actually it is, with non defined or empty string values. Test plan: Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included. => Without this patch you should get an error => With this patch applied you should see the search results Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 58261 [details] [review] Bug 17764: (bug 17556 follow-up) Fix search for logged out users and lost items If you are non logged-in and you the search result contain lost items, you will get: Can't call method "category" on an undefined value at /home/liz/koha-src/koha/C4/Search.pm line 2091. This is because bug 17556 assumed that $userenv was not defined when the user is logged out. Actually it is, with non defined or empty string values. Test plan: Do a search in the opac that would turn up a whole list of results (and not just that one) with the lost item included. => Without this patch you should get an error => With this patch applied you should see the search results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the 17.05 release! Thanks!
Dependency is not in 16.11.