If #findborrower does not exist, you cannot define _renderItem.
Created attachment 58273 [details] [review] Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
*** Bug 17789 has been marked as a duplicate of this bug. ***
Created attachment 58274 [details] [review] Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 58289 [details] [review] Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This #findborrower element is present on almost every page, it makes sense to keep it in js_includes.inc
Pushed to master for 17.05, thanks Marcel!
js_includes.inc was introduced by bug 17416 which is not in 16.11.x - bug fix is not needed in 16.11.x.