We had a library reporting that records show up on this report that haven't been checked out within the selected date range of checkout dates. After looking at the script I think this is because it checks the timestamp column instead of the issuedate of old_issues. In old_issues the timestamp is the date of return, so that's not right and explains the results the library reported. Side note: the report does also not seem to count current checkouts as it avoids the issues table?
Appears to be still valid.
+1, still valid
Created attachment 109246 [details] [review] Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search
Created attachment 109588 [details] [review] Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Indeed, timestamp can not be trusted. Nice work ;)
Created attachment 109597 [details] [review] Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another nice old one to have squelched. Works well, trivial patch.. Passing QA
> Side note: the report does also not seem to count current checkouts as it avoids the issues table? See Bug 10188
*** Bug 12628 has been marked as a duplicate of this bug. ***
Pushed to master for 20.11, thanks to everybody involved!
A lot of libraries have seen this bug, please backport to stable branches.
backported to 20.05.x for 20.05.04
backported to 19.11.x for 19.11.10
Great :D thanks a lot
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.