very easy, just change string showing when edit rule for reproduce: 1- Administration 2- Circulation and fines rules 3- When try to edit any rule, you have the message : Are you sure you want to edit another rule? The new message is : Are you sure you want to edit this rule ?
Hm, I feel like the bug is that it shows when you first pick a rule - it should only show when you change editing to another without saving first.
Created attachment 58389 [details] [review] Bug 17808: String change - message showing for rule edit confirmation
I still think the bug is not the text, it's the behaviour. I even think it used to work differently.
Created attachment 58408 [details] [review] Bug 17808: Fix behavior when editing a circ rule The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs Test plan: Edit a circ rule => Without this patch you get a useless message => With this patch, no message Edit a circ rule with content in inputs => With or without this patch you get a useful message
Created attachment 58652 [details] [review] [SIGNED OFF] Bug 17808: Fix behavior when editing a circ rule The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs Test plan: Edit a circ rule => Without this patch you get a useless message => With this patch, no message Edit a circ rule with content in inputs => With or without this patch you get a useful message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 58983 [details] [review] Bug 17808: Fix behavior when editing a circ rule The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs Test plan: Edit a circ rule => Without this patch you get a useless message => With this patch, no message Edit a circ rule with content in inputs => With or without this patch you get a useful message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This is definitely an improvement but a case worth mentioning: Change a bunch of the dropdowns and enter no other data, no warning on editing a new rule. I don't know if it would be feasible to tackle this, and the current patches offer huge improvement so marking PQA
Pushed to master for 17.05, thanks Jonathan!
This patch has been pushed to 16.11.x and will be in 16.11.02.
Pushed to 16.05.x, for 16.05.08 release