Some people have not save loans because they forgot to clic again on "enter item barcode" space after taking the option "on-site check out" 1)Go to Circulation module 2)Go to checkouts 3)Select a valid user for a loan 4)Observe the cursor is in "enter item barcode" space 4)Select the option "on-site check out" 5)Observe that the cursor isn't returning to "enter item barcode space" by itself Eliminate this additionnal clic can save lot of time to people doing many loans at a same time. Thanks for the support, Alexandre from CCSR
Created attachment 58566 [details] [review] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking the "on-site checkouts" box the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable the OnSiteCheckouts system preference. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the "On-site checkout" label or checkbox. - Confirm that the focus has moved to the barcode field.
Created attachment 58651 [details] [review] [SIGNED-OFF] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking the "on-site checkouts" box the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable the OnSiteCheckouts system preference. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the "On-site checkout" label or checkbox. - Confirm that the focus has moved to the barcode field. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
To be consistent should not we have the same behaviour for "Automatic renewal"? I personally don't really like that kind of custom javascript, especially when that can be achieve by filling the intranet js pref. But I am not behind a circulation desk :)
Created attachment 63038 [details] [review] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field.
Created attachment 63136 [details] [review] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch>
Patch tested with a sandbox, by Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca>
Created attachment 63145 [details] [review] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca>
Created attachment 63213 [details] [review] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Owen!
This patch has been pushed to 16.11.x and will be in 16.11.08. Marked as enhancement, but I think it might be annoying enough to qualify as a but for some.
Pushed to 16.05.x, for 16.05.13 release