Created attachment 58490 [details] [review] patch Not translated "by" before the authors in the search results window in staff interface (MARC21). In attachment patch for MARC21slim2intranetResults.xsl
Hi Serhij, can you please try to make a valid git patch file? You can use the git format-patch command or tCan you detail the problem a bit more? I am not sure why the mapping should be a problem.he git bz tool described in our wiki. Maybe the by should still be wrapped in a class? That way we could hide the whole line still without the by remaining.
Created attachment 59578 [details] [review] New version of patch (git format-patch)
Before this patch in file en-GB-marc-MARC21.po present next paragraph: #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed the following command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: #: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:348 #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by " And the string " by " becomes available for translation in uk-UA/xslt/MARC21slim2intranetResults.xsl (and other language versions) This can be checked the command sudo koha-translate --update uk-UA In the file uk-UA/xslt/MARC21slim2intranetResults.xsl string 'by <p class = "author">' is now translated.
(In reply to Katrin Fischer from comment #1) > Hi Serhij, can you please try to make a valid git patch file? > You can use the git format-patch command or tCan you detail the problem a > bit more? I am not sure why the mapping should be a problem.he git bz tool > described in our wiki. > Maybe the by should still be wrapped in a class? That way we could hide the > whole line still without the by remaining. 'by' not wrapped in class also in MARC21slim2OPACResults.xsl http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl;h=7349b816a61a7a4e712e2531d4d5b36ccb3b1b75;hb=refs/heads/master#l459
Hi Serhij, the patch looks good now, but I have one concern: The class=author was added to make it possible for libraries to hide the information if they want to. That's why the 'by' was inside. Can we find a way that fixes both needs?
Created attachment 66345 [details] [review] new patch Perhaps the comment "!-- #13383 --" after the text term removed this term from translation... Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: #: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:349 #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by "
Hi Serhij, thx for investigating! I have signed off on your patch with some little changes: - The subject should always start with "Bug xxxx" as this helps our tools to recognize what the patch is for and is used to link all the things together. - The patch commit message should contain a short description of the problem and the test plan (just copied your test plan in)
Created attachment 66510 [details] [review] Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {Сергій Дубик} <serhijdubyk@gmail.com> The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 66687 [details] [review] Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {Сергій Дубик} <serhijdubyk@gmail.com> The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.04.
This patch has been pushed to 16.11.x and will be in 16.11.12.
Pushed to 16.05.x, for 16.05.17 release