It seems that we want to keep this code, just open this bug report for reference. See Bug 8352 - Add automatic printing of 'hold to pull' notices Bug 16764 - Update printers administration page Bug 2045 - Network Printers Setting Does Nothing?
I am proposins to remove the code until it's needed. At the moment we have a page we need to maintain and keep secure that is not used at all. I think if there was a patch needing that kind if configuration page, it would be easy to bring it back.
Created attachment 79008 [details] [review] Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option
Got one QA tool error: FAIL circ/returns.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't locate C4/Print.pm in @INC (you may need to install the C4::Print module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) I assume the "POD coverage was greater before" warning is not relevant.
Created attachment 79553 [details] [review] Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option
Hi Owen, I think I forgot to submit that - there was one use C4::Print; left. Fixed now, thx for testing!
Created attachment 79598 [details] [review] Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Found 3 smalls things: 1. installer/data/mysql/atomicupdate/bug_17845_remove_printers should be a .perl and DROP COLUMN should only be executed if the column exists (column_exists) 2. koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc: <!-- <li><a href="/cgi-bin/koha/admin/printers.pl">Network Printers</a></li> --> Can be removed 3. in circulation.tt: 604 <input type="hidden" name="print" value="maybe" /> Can be removed as well TODO later: rename selectbranchprinter(.pl|.tt) Note: I have checked the set_userenv calls and they are all good.
Created attachment 100396 [details] [review] Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 100397 [details] [review] Bug 17845: Update atomic update for new format Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 100398 [details] [review] Bug 17845: (QA follow-up) Remove commented line A commented line still refered to the removed page from the admin-menu.inc Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 100399 [details] [review] Bug 17845: (QA follow-up) Remove hidden print input As highlighted by Jonathan, the hidden 'print' form field is no longer read and thus no longer required in the template. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 100400 [details] [review] Bug 17845: Remove some missed references to branchprinter Remove a few last references to branchprinter, mostly from tests. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice work Katrin! It would be great to see this one finished off.. I've added a few followups to fix the missing parts, address QA concerns and bring it up to date.. and as such didn't feel I should PQA as part of it.. Back to you Jonathan (or any other friendly QA person)
Created attachment 100427 [details] [review] Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100428 [details] [review] Bug 17845: Update atomic update for new format Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100429 [details] [review] Bug 17845: (QA follow-up) Remove commented line A commented line still refered to the removed page from the admin-menu.inc Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100430 [details] [review] Bug 17845: (QA follow-up) Remove hidden print input As highlighted by Jonathan, the hidden 'print' form field is no longer read and thus no longer required in the template. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100431 [details] [review] Bug 17845: Remove some missed references to branchprinter Remove a few last references to branchprinter, mostly from tests. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100432 [details] [review] Bug 17845: Adjust few other occurrences Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100433 [details] [review] Bug 17845: Remove the column if it exists Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100434 [details] [review] Bug 17845: Schema changes
(In reply to Jonathan Druart from comment #9) > TODO later: rename selectbranchprinter(.pl|.tt) I opened bug 24837.
Nice work everyone! Pushed to master for 20.05
Thx a lot for finishing this one!
enhancement not backported to 19.11.x