Created attachment 79342 [details] [review]
Bug 17854: Adds print/close icon in checkout

To Test:
1) Apply Patch.
2) Go to a patron checkout screen (circulation.pl).
3) Note there are no clear screen buttons in the upper right corner of
the checkout window.
4) Turn on the DisplayClearScreenButton preference.
5) Go back to patron checkout.  Note the clear screen button and the new
printer icon next to it.
6) Click the printer icon.  This will trigger a print slip function, and
close the patron screen.
7) Try to arrow back to the previous screen.  Should go to main menu and
not the patron screen, just like the orginal close button (X).

I have a patch ready for testing, however, this does not address all my requests.  It does print the slip.  It is the same function as the Print Slip choice.  However, I know this does not address the issue if someone would rather print a quick slip and close.

We could either:

A) add another button next to the new button for a quick slip/close.
or
B) add a dropdown selector next to the button that would choose a default behavior and store the choice in a cookie.


Option B is more complicated and I would need someone else to step in as I don't know a thing about cookies.  I could easily do option A.

Thoughts?

BTW, when you load the patch, you will need to:
 
$ yarn build

to update the css. Without it, the button will not be in the correct place or have the correct look.  Sandbox testers will not be able to test without this ability.

UPDATED TEST PLAN:
1) Apply Patch.
2) Run yarn build to update the css (Sorry sandbox testers!).
3) Go to a patron checkout screen (circulation.pl).
4) Note there are no clear screen buttons in the upper right corner of
the checkout window.
5) Turn on the DisplayClearScreenButton preference.
6) Go back to patron checkout.  Note the clear screen button and the new
printer icon next to it.
7) Click the printer icon.  This will trigger a print slip function, and
close the patron screen.
8) Try to arrow back to the previous screen.  Should go to main menu and
not the patron screen, just like the orginal close button (X).

See Comment 2 for discussion.

Since the CircAutoPrintQuickSlip includes all the options you want, why not tie that preference to the DisplayClearScreenButton to get what you want? 

IF DisplayClearScreenButton is ON, clicking the clear screen button would trigger the action defined in CircAutoPrintQuickSlip.

Created attachment 79384 [details] [review]
Bug 17854: Adds print/close icon in checkout

To Test:
1) Apply Patch.
2) Go to a patron checkout screen (circulation.pl).
3) Note there are no clear screen buttons in the upper right corner of
the checkout window.
4) Turn on the DisplayClearScreenButton preference.
5) Go back to patron checkout.  Note the clear screen button and the new
printer icon next to it.
6) Click the printer icon.  This will trigger a print slip function, and
close the patron screen.
7) Try to arrow back to the previous screen.  Should go to main menu and
not the patron screen, just like the orginal close button (X).

Signed-off-by: Michal Denar <black23@gmail.com>

(In reply to Owen Leonard from comment #6)
> Since the CircAutoPrintQuickSlip includes all the options you want, why not
> tie that preference to the DisplayClearScreenButton to get what you want? 
> 
> IF DisplayClearScreenButton is ON, clicking the clear screen button would
> trigger the action defined in CircAutoPrintQuickSlip.

Man!  I didn't remember that.  Wish someone mentioned it in the almost 2 years this was reported.  I would have gone that route.  But my button was pretty cute!  :)  I'll put this to a discussion and try an alternative patch with that suggestion.  :)  Thanks....OWEN.  :)

Actually, I am going to put this back to needs signoff and go back to my question in comment 2.

I don't want to pursue the CircAutoPrintQuickSlip preference, and here is why - It is an all or nothing setting.  As a member of a consortium, this would be a problem.  Not all our libraries have printers.  Not everyone wants to print the same slip.  That particular setting should have been incorporated under the library settings, or modified so that it could be set per library.

Created attachment 79942 [details] [review]
Bug 17854: Adds print/close icon in checkout

To Test:
1) Apply Patch.
2) Go to a patron checkout screen (circulation.pl).
3) Note there are no clear screen buttons in the upper right corner of
the checkout window.
4) Turn on the DisplayClearScreenButton preference.
5) Go back to patron checkout.  Note the clear screen button and the new
printer icon next to it.
6) Click the printer icon.  This will trigger a print slip function, and
close the patron screen.
7) Try to arrow back to the previous screen.  Should go to main menu and
not the patron screen, just like the orginal close button (X).

Signed-off-by: Michal Denar <black23@gmail.com>

Setting back to signed off, since no one has anything to say about it.

Created attachment 84472 [details] [review]
Bug 17854: Adds print/close icon in checkout

To Test:
1) Apply Patch.
2) Go to a patron checkout screen (circulation.pl).
3) Note there are no clear screen buttons in the upper right corner of
the checkout window.
4) Turn on the DisplayClearScreenButton preference.
5) Go back to patron checkout.  Note the clear screen button and the new
printer icon next to it.
6) Click the printer icon.  This will trigger a print slip function, and
close the patron screen.
7) Try to arrow back to the previous screen.  Should go to main menu and
not the patron screen, just like the orginal close button (X).

Signed-off-by: Michal Denar <black23@gmail.com>

Awesome work all!

Pushed to master for 19.05

Enhancement, will not be backported to 18.11.x series.