Bug 17793 corrects tabs visible in the search area. These tests will check those.
Created attachment 58655 [details] [review] Test Cases
Comment on attachment 58655 [details] [review] Test Cases Wrong patch.
Created attachment 58656 [details] [review] Test Cases
I think that should also test: searchengine/elasticsearch/mappings.pl clone-rules.pl (see comment 12 on bug 17793) preferences.pl systempreferences.pl
Created attachment 58685 [details] [review] Bug 17864: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 58686 [details] [review] Bug 17864: Follow up to add missing tests This adds tests for the missing items. Remember the kohadevbox has annoying caching issues, so close tab, vagrant halt, vagrant up just to be certain you are not failing because of caching.
Looks like I forgot to change the status back to needs sign off. :)
P.S. This fails if plug ins are not enabled, as one of the tested pages is plugins. :)
Created attachment 64435 [details] [review] Bug 17864: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> https://bugs.koha-community.org/show_bug.cgi?id=17864 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Updated commit subject to reflect correct bug number. Works as directed according to test plan and passes QA tools.
Created attachment 64436 [details] [review] Bug 17864: Follow up to add missing tests This adds tests for the missing items. Remember the kohadevbox has annoying caching issues, so close tab, vagrant halt, vagrant up just to be certain you are not failing because of caching. Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
I am not sure to understand how useful these regression tests can be.
Created attachment 66748 [details] [review] Bug 17793: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> https://bugs.koha-community.org/show_bug.cgi?id=17864 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 66749 [details] [review] Bug 17864: Follow up to add missing tests This adds tests for the missing items. Remember the kohadevbox has annoying caching issues, so close tab, vagrant halt, vagrant up just to be certain you are not failing because of caching. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Jonathan Druart from comment #11) > I am not sure to understand how useful these regression tests can be. Answer still needed.