When there is only one branch in an installation, it makes no sense to show a pick-up library column in the holds list in the patron account in OPAC. We should remove it from display, as we do in other spots.
Created attachment 70541 [details] [review] Bug 17869 Holds location removal Test Plan [1.] Type in browser http://localhost:8080/ (If you aren't logged in then log in) [2.] Then search for anything and click on the link 'Place hold' which is directly underneath the stars for an item [3.] Notice that there is a pick up location with only one location [4.] Load the patch and now notice that there is no location (as it is not necessary with only one location)
Patch tested with a sandbox, by claude <claude.brayer@cea.fr>
Created attachment 72763 [details] [review] Bug 17869 Holds location removal Test Plan [1.] Type in browser http://localhost:8080/ (If you aren't logged in then log in) [2.] Then search for anything and click on the link 'Place hold' which is directly underneath the stars for an item [3.] Notice that there is a pick up location with only one location [4.] Load the patch and now notice that there is no location (as it is not necessary with only one location) Signed-off-by: claude <claude.brayer@cea.fr>
Created attachment 72805 [details] [review] Bug 17869: Don't show pick up location on OPAC holds if only one library exists Test Plan [1.] Type in browser http://localhost:8080/ (If you aren't logged in then log in) [2.] Then search for anything and click on the link 'Place hold' which is directly underneath the stars for an item [3.] Notice that there is a pick up location with only one location [4.] Load the patch and now notice that there is no location (as it is not necessary with only one location) Signed-off-by: claude <claude.brayer@cea.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I do not recreate the bug on master, can you confirm it is still valid? The singleBranchMode test should do this job.
I think the original bug was misunderstood and you are right in that the patch is not needed.
What I meant was: - Make sure you only got 1 library in your installation - Place a hold, verify there is no pick-up location to select - Go to the patron account in OPAC - Go to summary - Pick tab holds - Verify you can see a pick-up location column there
Created attachment 76146 [details] [review] Bug 17869: Don't show pick-up library for list of holds in OPAC account when there is only one branch This patch modifies the user summary page in the OPAC so that the "pick up location" column isn't shown in the table of holds if there is only one library defined. To test, apply the patch and log into the OPAC as a user with one or more holds. - In a system with more than one library defined the "Holds" tab of opac-user.pl should show a "Pick up location" column. - In a system with only one library defined there should be now "Pick up location" column.
Created attachment 76252 [details] [review] Bug 17869: Don't show pick-up library for list of holds in OPAC account when there is only one branch This patch modifies the user summary page in the OPAC so that the "pick up location" column isn't shown in the table of holds if there is only one library defined. To test, apply the patch and log into the OPAC as a user with one or more holds. - In a system with more than one library defined the "Holds" tab of opac-user.pl should show a "Pick up location" column. - In a system with only one library defined there should be now "Pick up location" column. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx, Owen!
Created attachment 76516 [details] [review] Bug 17869: Don't show pick-up library for list of holds in OPAC account when there is only one branch This patch modifies the user summary page in the OPAC so that the "pick up location" column isn't shown in the table of holds if there is only one library defined. To test, apply the patch and log into the OPAC as a user with one or more holds. - In a system with more than one library defined the "Holds" tab of opac-user.pl should show a "Pick up location" column. - In a system with only one library defined there should be now "Pick up location" column. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02, trivial bugfix.
Pushed to 17.11.x for 17.11.08