In Bug 17418 I moved a line from doc-head-close.inc to js_includes.inc which I shouldn't have: -[% PROCESS 'html_helpers.inc' %] That file isn't JS and many pages depend on it being defined at the top of the page.
Affected would be any templates which include: [% PROCESS options_for_libraries... or [% PROCESS options_for_authorised_value_categories... ...because those blocks are defined in html_helpers.inc. The breakage would only occur if you tried to add [% SET footerjs = 1 %] to any of those templates.
Created attachment 58705 [details] [review] Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly.
Created attachment 58719 [details] [review] Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Created attachment 58720 [details] [review] Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Owen!
This depends on bug 17418, which is not in 16.11.