Bug 17877 - Show internal and vendor note in acquisition info on subscription detail page
Summary: Show internal and vendor note in acquisition info on subscription detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 20726
Blocks:
  Show dependency treegraph
 
Reported: 2017-01-10 15:32 UTC by Katrin Fischer
Modified: 2019-10-14 19:58 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17877: Add columns settings to the orders table on subscription-detail (4.37 KB, patch)
2018-09-19 22:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 17877: Add the order's notes to the table (2.73 KB, patch)
2018-09-19 22:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 17877: Add columns settings to the orders table on subscription-detail (4.41 KB, patch)
2018-09-20 08:45 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 17877: Add the order's notes to the table (2.83 KB, patch)
2018-09-20 08:45 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 17877: Add columns settings to the orders table on subscription-detail (4.47 KB, patch)
2018-09-25 06:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 17877: Add the order's notes to the table (2.83 KB, patch)
2018-09-25 06:06 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-01-10 15:32:53 UTC
When using the 'order from subscription' feature in the acquisitions module, Koha shows acquisitions information on the subscription detail page in serials.

It would be helfpul to also show the vendor and internal note from the acquisition order on this page.
Comment 1 Séverine Queune 2018-03-09 13:48:19 UTC
The BULAC (http://www.bulac.fr/) would like to sponsor this development !

As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>.
Comment 2 Jonathan Druart 2018-05-29 19:27:16 UTC
On top of bug 20726, I am going to add the internal notes with the configuration columns setting on this bug report.
Comment 3 Katrin Fischer 2018-09-06 15:15:25 UTC
Is this still planned?
Comment 4 Jonathan Druart 2018-09-19 22:57:41 UTC
Created attachment 79127 [details] [review]
Bug 17877: Add columns settings to the orders table on subscription-detail

Test plan:
- Apply this patch and make sure to restart memcached (to re-read the yaml
file that is cached)
- Go to Home › Administration › Columns settings
- Confirm that a new "Serials" tab contain the different columns of the
"Acquisition details" table displayed on the subscription detail page
(if an order exist for this subscription)
- Play with it
- Go to Home › Serials › Details for subscription #ID
- Confirm that the "Column visibility" button is now displayed on top of
the table that it works correctly.
Comment 5 Jonathan Druart 2018-09-19 22:57:46 UTC
Created attachment 79128 [details] [review]
Bug 17877: Add the order's notes to the table

This patch adds the vendor and internal note from the acquisition order
to the subscription detail page

Test plan:
- Create an order from a subscription, fill the internal and vendor
notes
- Go to the subscription's detail page
- Confirm that the columns are displayed in the "Acquisition details"
table and contain the correct values
- Make sure the "Home › Administration › Columns settings" admin page
let you hide them by default (for those who will not need them).
Comment 6 Biblibre Sandboxes 2018-09-20 08:45:12 UTC
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Comment 7 Biblibre Sandboxes 2018-09-20 08:45:47 UTC
Created attachment 79136 [details] [review]
Bug 17877: Add columns settings to the orders table on subscription-detail

Test plan:
- Apply this patch and make sure to restart memcached (to re-read the yaml
file that is cached)
- Go to Home › Administration › Columns settings
- Confirm that a new "Serials" tab contain the different columns of the
"Acquisition details" table displayed on the subscription detail page
(if an order exist for this subscription)
- Play with it
- Go to Home › Serials › Details for subscription #ID
- Confirm that the "Column visibility" button is now displayed on top of
the table that it works correctly.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 8 Biblibre Sandboxes 2018-09-20 08:45:50 UTC
Created attachment 79137 [details] [review]
Bug 17877: Add the order's notes to the table

This patch adds the vendor and internal note from the acquisition order
to the subscription detail page

Test plan:
- Create an order from a subscription, fill the internal and vendor
notes
- Go to the subscription's detail page
- Confirm that the columns are displayed in the "Acquisition details"
table and contain the correct values
- Make sure the "Home › Administration › Columns settings" admin page
let you hide them by default (for those who will not need them).

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 9 Katrin Fischer 2018-09-25 06:06:55 UTC
Created attachment 79355 [details] [review]
Bug 17877: Add columns settings to the orders table on subscription-detail

Test plan:
- Apply this patch and make sure to restart memcached (to re-read the yaml
file that is cached)
- Go to Home › Administration › Columns settings
- Confirm that a new "Serials" tab contain the different columns of the
"Acquisition details" table displayed on the subscription detail page
(if an order exist for this subscription)
- Play with it
- Go to Home › Serials › Details for subscription #ID
- Confirm that the "Column visibility" button is now displayed on top of
the table that it works correctly.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2018-09-25 06:06:59 UTC
Created attachment 79356 [details] [review]
Bug 17877: Add the order's notes to the table

This patch adds the vendor and internal note from the acquisition order
to the subscription detail page

Test plan:
- Create an order from a subscription, fill the internal and vendor
notes
- Go to the subscription's detail page
- Confirm that the columns are displayed in the "Acquisition details"
table and contain the correct values
- Make sure the "Home › Administration › Columns settings" admin page
let you hide them by default (for those who will not need them).

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Nick Clemens 2018-10-01 16:42:59 UTC
Awesome work all!

Pushed to master for 18.11
Comment 12 Martin Renvoize 2018-10-05 15:43:13 UTC
Enhancement will not be backported to 18.05.x series