This is a problem because the image name is used in the patron card layout editor, and if a person uploads a bunch of images with no names then it will be difficult to tell which image is which.
Created attachment 58788 [details] [review] Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT
Created attachment 58795 [details] [review] Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Created attachment 58798 [details] [review] Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Aleisha!
Reclassifying this to be a bug - This patch has been pushed to 16.11.x and will be in 16.11.02.
Pushed to 3.22.x for 3.22.15
Pushed to 16.05.x, for 16.05.08 release