If you try something like the following when DateTime isn't installed, instead of seeing the Perl dependency information, you'll see nulls and hard-coded defaults. my $version_check = $modules->version_info('module'=>"DateTime"); This is only a problem when using version_info with the module parameter. The "all" parameter (as used by koha_perl_deps.pl) works fine. It looks like a simple copy/paste error, so I'll post a patch for this too soon.
Created attachment 58851 [details] [review] Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency.
Created attachment 58852 [details] [review] Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used.
Created attachment 58853 [details] [review] Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used.
Created attachment 58854 [details] [review] Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency.
Created attachment 58855 [details] [review] Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used.
Test Plan: 1) Apply patch "Bug 17882 - Add missing module test to Installer_PerlModules.t". 2) Run "perl t/Installer_PerlModules.t" 3) Note the following at the end of the test output: not ok 18 - Minimum version found for missing module # Failed test 'Minimum version found for missing module' # at t/Installer_PerlModules.t line 48. # got: undef # expected: '0.9.3' # Looks like you planned 17 tests but ran 18. # Looks like you failed 1 test of 18 run. 4) Apply patch "Bug 17882 - Fix C4::Installer::PerlModules::version_info()". 5) Run "perl t/Installer_PerlModules.t" 6) Note the following at the end of the test output: ok 18 - Minimum version found for missing module
Arg... just noticed the usage doesn't show up for upgrades and installed modules...
*** This bug has been marked as a duplicate of bug 17990 ***