Bug 10459 has been backported and the DB entry (add borrowers.updated_on and deletedborrower.updated_on) is now played in - 16.06.00.027 - 16.05.00.002 - 3.22.08.001 This will raise a MySQL warning if the column already exists. DBD::mysql::db do failed: Duplicate column name 'updated_on' Since bug 17234 we have now a subroutine (C4::Installer::column_exists) to test if a column exists. When a DB entry modifying the DB structure is backported, it HAS TO check if the column, constraint or table exists before executing the query.
Created attachment 59004 [details] [review] Bug 17914: Do not try and add the updated_on columns to the borrowers and deletedborrowers table Bug 10459 has been backported and the DB entry (add borrowers.updated_on and deletedborrower.updated_on) is now played in - 16.06.00.027 - 16.05.00.002 - 3.22.08.001 This will raise a MySQL warning if the column already exists. DBD::mysql::db do failed: Duplicate column name 'updated_on' Since bug 17234 we have now a subroutine (C4::Installer::column_exists) to test if a column exists. When a DB entry modifying the DB structure is backported, it HAS TO check if the column, constraint or table exists before executing the query. Test plan: git checkout 3.22.x (16.05.x or 16.11.x) install Koha git checkout master execute the installer => Without this patch you will get a warning when adding borrowers.updated_on) => With this patch, you should not get it
You can fix a lot of db revs in that regard..
(In reply to Marcel de Rooy from comment #2) > You can fix a lot of db revs in that regard.. We do not have a lot that have been backported.
Created attachment 59018 [details] [review] Bug 17914: Do not try and add the updated_on columns to the borrowers and deletedborrowers table Bug 10459 has been backported and the DB entry (add borrowers.updated_on and deletedborrower.updated_on) is now played in - 16.06.00.027 - 16.05.00.002 - 3.22.08.001 This will raise a MySQL warning if the column already exists. DBD::mysql::db do failed: Duplicate column name 'updated_on' Since bug 17234 we have now a subroutine (C4::Installer::column_exists) to test if a column exists. When a DB entry modifying the DB structure is backported, it HAS TO check if the column, constraint or table exists before executing the query. Test plan: git checkout 3.22.x (16.05.x or 16.11.x) install Koha git checkout master execute the installer => Without this patch you will get a warning when adding borrowers.updated_on) => With this patch, you should not get it Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 59095 [details] [review] Bug 17914: Do not try and add the updated_on columns to the borrowers and deletedborrowers table Bug 10459 has been backported and the DB entry (add borrowers.updated_on and deletedborrower.updated_on) is now played in - 16.06.00.027 - 16.05.00.002 - 3.22.08.001 This will raise a MySQL warning if the column already exists. DBD::mysql::db do failed: Duplicate column name 'updated_on' Since bug 17234 we have now a subroutine (C4::Installer::column_exists) to test if a column exists. When a DB entry modifying the DB structure is backported, it HAS TO check if the column, constraint or table exists before executing the query. Test plan: git checkout 3.22.x (16.05.x or 16.11.x) install Koha git checkout master execute the installer => Without this patch you will get a warning when adding borrowers.updated_on) => With this patch, you should not get it Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Jonathan!
This patch has been pushed to 16.11.x and will be in 16.11.02.
Pushed to 16.05.x, for 16.05.08 release