To reproduce: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. Adding "use C4::Letters" to Koha/Patron/Password/Recovery.pm fixes this. Patch coming in a sec.
Created attachment 59094 [details] [review] Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off
Created attachment 59132 [details] [review] Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com>
Created attachment 59233 [details] [review] Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I don't actually get the error, but better to add the use explicitly
Pushed to master for 17.05, thanks Magnus!
This patch has been pushed to 16.11.x and will be in 16.11.02.
Pushed to 16.05.x, for 16.05.08 release