Created attachment 59096 [details] [review] Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log Open Reports/Patrons with the most checkouts Check the log for warnings after the restart. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Eyeballs well.
Created attachment 59208 [details] [review] Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log. Open Reports/Patrons with the most checkouts. Check if the file in /tmp has not been created again. Check the log for warnings after you restarted Plack. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Something weird while testing, not related to this bug but I write it down for the records: The column 'Patron' contains values like surname,[tab]first name e.g. Meier, Hans That will break any csv import using tab or , as separator
Created attachment 63316 [details] [review] Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log. Open Reports/Patrons with the most checkouts. Check if the file in /tmp has not been created again. Check the log for warnings after you restarted Plack. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mason James <mtj@kohaaloha.com>
seems to work as expected, thanks Marcel!
Created attachment 63337 [details] [review] Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log. Open Reports/Patrons with the most checkouts. Check if the file in /tmp has not been created again. Check the log for warnings after you restarted Plack. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Marcel!
This patch has been pushed to 16.11.x and will be in 16.11.08.
Pushed to 16.05.x, for 16.05.13 release