Created attachment 59160 [details] [review] Bug 17931: Remove unused vars from reserves_stats Change to Modern::Perl. Remove null_to_zzempty and add a few blank lines between subs. Remove unused vars: $podsp, $type, $daysel, $monthsel and $mime. Removing trailing 1; Test plan: Run a few reports from reports/reserves_stats.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 59191 [details] [review] Bug 17931: Remove unused vars from reserves_stats Change to Modern::Perl. Remove null_to_zzempty and add a few blank lines between subs. Remove unused vars: $podsp, $type, $daysel, $monthsel and $mime. Removing trailing 1; Test plan: Run a few reports from reports/reserves_stats.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emma Smith <emma.nakamura.smith@gmail.com>
(In reply to Emma from comment #2) > Signed-off-by: Emma Smith <emma.nakamura.smith@gmail.com> Thanks, Emma.
Created attachment 59232 [details] [review] Bug 17931: Remove unused vars from reserves_stats Change to Modern::Perl. Remove null_to_zzempty and add a few blank lines between subs. Remove unused vars: $podsp, $type, $daysel, $monthsel and $mime. Removing trailing 1; Test plan: Run a few reports from reports/reserves_stats.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emma Smith <emma.nakamura.smith@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Wrongly pasted from reports/issues_stats.pl initially
Pushed to master for 17.05, thanks Marcel!
This patch has been pushed to 16.11.x and will be in 16.11.02.
Pushed to 16.05.x, for 16.05.08 release