This will build on the patch bug 17823.
Created attachment 59204 [details] [review] Bug 17938 - XSLT: if 583 is repeated, the label will appear multiple times Test plan 1) Edit a record 2) Repeat the Action note tag to add another Action note 3) Save record and confirm that the Action note label appears multiple times. 4) Apply patch and refresh page 5) All Action notes should now be on one line and separated by "|"
Hi Karen, I think there may be a bug in your patch - without an indicator, or with indicator 0, the notes do not display, but the action-note label and associated pipe separators do. Thanks for having a look into this problem though! Cheers, Liz
Created attachment 102025 [details] Bug 17983: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space
Created attachment 102053 [details] [review] Bug 17938: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space https://bugs.koha-community.org/show_bug.cgi?id=17938 Signed-off-by: David Nind <david@davidnind.com>
Created attachment 102120 [details] [review] Bug 17938: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Katrin, please adjust bug report's title (the most important part to me is the display of the private notes staff-side)
(In reply to Jonathan Druart from comment #6) > Katrin, please adjust bug report's title (the most important part to me is > the display of the private notes staff-side) You are right - thank you. Actually surprising that it hasn't worked this way before?
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x branch for 19.11.06
backported to 19.05.x for 19.05.11