To trigger, turn on syspref "SearchMyLibraryFirst" and go back to OPAC. You'll see by the search bar it now says 'Search (in <branchcode> only), which isn't very user-friendly.
Created attachment 59293 [details] [review] Bug 17947 Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only)
Comment on attachment 59293 [details] [review] Bug 17947 Searching my library first shows the branchcode by the search bar rather than branchname Review of attachment 59293 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ +155,4 @@ > <label for="masthead_search"> Search > [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %] > [% IF ( mylibraryfirst ) %] > + (in [% LibraryNameTitle %] only) This is based on the systempreference LibraryName. Perhaps Branches.GetName(mylibraryfirst) is a better choice?
> - (in [% mylibraryfirst %] only) > + (in [% LibraryNameTitle %] only) As M. Tompsett says, [% LibraryNameTitle %] is not going to show you the name of the user's library branch, but the name of the library "system" in a multi-branch situation. The suggestion is to use this instead: (in [% Branches.GetName( mylibraryfirst ) %] only) This uses a template plugin to pull the correct library branch name based on the branchcode output by 'mylibraryfirst' Because this patch doesn't work as expected, I'm setting this to Failed QA.
Created attachment 59470 [details] [review] Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT
Created attachment 59479 [details] [review] Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 59570 [details] [review] Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 60320 [details] [review] Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in <Branch Code> Only) 3: Apply patch and refresh page. It should now say Search (in <Library Name> only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Aleisha!
String change - will come back to this after release of 16.11.04.
It's marked enhancement, but I think it should have always been the name not the code - so I'd say it's more a bug. What do others think?
I've decided to backport this - I think showing the branch name is the correct thing, especially to users in the OPAC. This patch has been pushed to 16.11.x and will be in 16.11.05.
Pushed to 3.22.x, will be in 3.22.18
Pushed to 16.05.x, for 16.05.11 release