<<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable.
Created attachment 59414 [details] [review] Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch.
Created attachment 61637 [details] [review] Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 63976 [details] [review] Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17969: Refactor the way <<items.content>> is generated
Created attachment 65364 [details] [review] Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 65567 [details] [review] Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 65568 [details] [review] Bug 17969: (QA followup) Add POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 65684 [details] [review] Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 65685 [details] [review] Bug 17969: (QA followup) Add POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x
<< >> in the title were not working well with the html version of the release notes.