17974 – Add the Koha::Item->biblio method

Bug 17974 - Add the Koha::Item->biblio method

Summary: Add the Koha::Item->biblio method

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Jonathan Druart
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:	17966 18264
	Show dependency tree / graph

Reported:	2017-01-23 16:56 UTC by Jonathan Druart
Modified:	2018-12-03 20:05 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 17974: Add the Koha::Item->biblio method (1.87 KB, patch) 2017-01-23 16:59 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 17974: Add the Koha::Item->biblio method (1.94 KB, patch) 2017-01-23 21:41 UTC, Josef Moravec	Details \| Diff \| Splinter Review
Bug 17974: Add the Koha::Item->biblio method (1.98 KB, patch) 2017-02-16 11:08 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Bug 17974 (QA Followup) (892 bytes, patch) 2017-02-16 11:08 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2017-01-23 16:56:49 UTC

Comment 1 Jonathan Druart 2017-01-23 16:59:31 UTC

Created attachment 59441 [details] [review]
Bug 17974: Add the Koha::Item->biblio method

Test plan:
  prove t/db_dependent/Koha/Items.t
should return green

Comment 2 Josef Moravec 2017-01-23 21:41:11 UTC

Created attachment 59464 [details] [review]
[SIGNED-OFF] Bug 17974: Add the Koha::Item->biblio method

Test plan:
  prove t/db_dependent/Koha/Items.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Comment 3 Nick Clemens (kidclamp) 2017-02-16 11:08:11 UTC

Created attachment 60327 [details] [review]
Bug 17974: Add the Koha::Item->biblio method

Test plan:
  prove t/db_dependent/Koha/Items.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 4 Nick Clemens (kidclamp) 2017-02-16 11:08:20 UTC

Created attachment 60328 [details] [review]
Bug 17974 (QA Followup)

Use the $biblio_rs variable

    In case of Koha::Object you can call new_from_dbic directly, however,
    it fails for Koha::Objects so using an intermediary variable should
    be done for consistency

Comment 5 Kyle M Hall (khall) 2017-02-17 12:12:20 UTC

Pushed to master for 17.05, thanks Jonathan, Nick!

Comment 6 Katrin Fischer 2017-02-19 20:24:52 UTC

This won't get ported back to 16.11.x as it is an enhancement.

Comment 7 Katrin Fischer 2017-06-05 13:45:03 UTC

Reconsidered decision and pushed to 16.11.x as this is a dependency on bug 18264.

Comment 8 Mason James 2017-07-31 11:15:23 UTC

Pushed to 16.05.x, for 16.05.15 release