As bug 17932 introduced the TO_JSON method there's no need to call ->unblessed anymore. As this is a reference implementation, I fix it to the new coding style.
Created attachment 59548 [details] [review] Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D
Created attachment 60750 [details] [review] Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Created attachment 60753 [details] [review] Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05, thanks Tomas!
Depends on bug 17932 which is not in 16.11.x.