Some small enhancements for the user experience - datatable - use of breadcrumbs for adding/modifying form - bootstrap 3 buttons on adding/modifying form
Created attachment 59763 [details] [review] Bug 18035: Front-end changes to serials -> Claims This patch: 1) Uses datatables functionality on numbering patterns table 2) Shows breadcrumbs when using the form to add or modify numbering patterns 3) Updates the Save, Reset, and Test Pattern buttons in the form to be bootstrap 3 buttons To test: 1) Confirm that datatable sorting works on all columns EXCEPT Actions column 2) Click 'New numbering pattern' 3) Confirm breadcrumbs reads 'New numbering pattern' 4) Go back to numbering patterns and Edit an existing one 5) Confirm breadcrumbs reads 'Modifying number pattern '<name of numbering pattern>' 6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3 buttons 7) Confirm all buttons work as expected Sponsored-by: Catalyst IT
7) Reset button doens't work: nothing happens.
(In reply to julien.comte from comment #2) > 7) Reset button doens't work: nothing happens. Reset button works perfectly for me. The button is meant to reset any changes you make to the last saved version of the numbering pattern, so it'll look like nothing happens unless you change something such as the Name of the pattern.
Does bug title fit? - "Front-end changes to serials -> Claims" Bug seems to be related to numbering patterns :-)
(In reply to Marc Véron from comment #4) > Does bug title fit? - "Front-end changes to serials -> Claims" > Bug seems to be related to numbering patterns :-) You're right! I'll change this.
Created attachment 61722 [details] [review] Bug 18035: Front-end changes to serials -> numbering patterns This patch: 1) Uses datatables functionality on numbering patterns table 2) Shows breadcrumbs when using the form to add or modify numbering patterns 3) Updates the Save, Reset, and Test Pattern buttons in the form to be bootstrap 3 buttons To test: 1) Confirm that datatable sorting works on all columns EXCEPT Actions column 2) Click 'New numbering pattern' 3) Confirm breadcrumbs reads 'New numbering pattern' 4) Go back to numbering patterns and Edit an existing one 5) Confirm breadcrumbs reads 'Modifying number pattern '<name of numbering pattern>' 6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3 buttons 7) Confirm all buttons work as expected Sponsored-by: Catalyst IT
Comment on attachment 59763 [details] [review] Bug 18035: Front-end changes to serials -> Claims Obsoleting first patch (with wrong title).
Created attachment 61731 [details] [review] Bug 18035: Front-end changes to serials -> numbering patterns This patch: 1) Uses datatables functionality on numbering patterns table 2) Shows breadcrumbs when using the form to add or modify numbering patterns 3) Updates the Save, Reset, and Test Pattern buttons in the form to be bootstrap 3 buttons To test: 1) Confirm that datatable sorting works on all columns EXCEPT Actions column 2) Click 'New numbering pattern' 3) Confirm breadcrumbs reads 'New numbering pattern' 4) Go back to numbering patterns and Edit an existing one 5) Confirm breadcrumbs reads 'Modifying number pattern '<name of numbering pattern>' 6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3 buttons 7) Confirm all buttons work as expected Sponsored-by: Catalyst IT Followed test plan works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 62949 [details] [review] Bug 18035: Front-end changes to serials -> numbering patterns This patch: 1) Uses datatables functionality on numbering patterns table 2) Shows breadcrumbs when using the form to add or modify numbering patterns 3) Updates the Save, Reset, and Test Pattern buttons in the form to be bootstrap 3 buttons To test: 1) Confirm that datatable sorting works on all columns EXCEPT Actions column 2) Click 'New numbering pattern' 3) Confirm breadcrumbs reads 'New numbering pattern' 4) Go back to numbering patterns and Edit an existing one 5) Confirm breadcrumbs reads 'Modifying number pattern '<name of numbering pattern>' 6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3 buttons 7) Confirm all buttons work as expected Sponsored-by: Catalyst IT Followed test plan works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Aleisha!
This won't get ported back to 16.11.x as it is an enhancement.