Good day, After upgrading Koha, when I try to view label batches at http://koha-server:8080/cgi-bin/koha/labels/label-manage.pl?label_element=batch it says that "There are no Batches currently available". I can create a new batch (e.g. I created a new batch numbered 27 and then another numbered 28, but I can't see the list of batches??? I can directly edit the Batches, e.g. http://koha-server:8080/cgi-bin/koha/labels/label-edit-batch.pl?op=edit&batch_id=27 http://koha-server:8080/cgi-bin/koha/labels/label-edit-batch.pl?op=edit&batch_id=28 So this tells me that there's a problem displaying the list of label batches. I'm running Koha 16.11.03.000 on Ubuntu 14.04.5 LTS Trusty with Apache Server version: Apache/2.4.7 (Ubuntu) and mysql Ver 15.1 Distrib 5.5.54-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2, Zebra 2.0.44 and Perl 5.018002. I tried looking in the Log files for any messages regarding labels but could not find any relevant log entries (even for creating the Batches I did), under Browse system logs. Regads Matthew
Bumping severity. Can anyone confirm this? I don't have an installation of this version handy.
I can confirm it on master too
I'm guessing it is related to bug 17900 (which I cannot access). The fix for this bug made extensive changes to the patron card code. Detail may be had here: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a70980d8255a66c33539926796c06b29b26fbb40
I'm adding Jonathan to this bug as he was the one who handled the aforementioned bug. Maybe he can have a look at what's going on here.
We probably need to verify that _build_query is construction the correct SQL for the case of $label_element eq 'batch'. That case is unique in that there is an OR in it. Can someone verify that the other cases of $label_element work as expected?
It would be nice to add a parameter to _build_query which would cause it to dump the resulting query and args to the log for debug use.
Should this be 'in discussion'? Being critical it would be good to get a fast fix, the problem is probably in all versions now due to the security fix. :(
I think it is just waiting for someone to take it. I'd work on it, but do not have a Koha dev setup available at all ATM. (Sad, I know.)
Better to use new then!
I'm cloning koha.git now... its huge.
Updating version to master
https://github.com/digibib/kohadevbox is fun for setting up dev environments - might be worth taking a look at :)
Created attachment 59909 [details] [review] Patch to fix missing list separators in SQL
This bug breaks critical functionality for many libraries. The fix is super-simple. If someone could QA this, and we could get it push up right away, that would be fantastic!
Created attachment 59912 [details] [review] Bug 18044: Label Batches not displaying SQL expects lists to be comma separated. A trailing comma must also be avoided. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 59913 [details] [review] Bug 18044: Label Batches not displaying SQL expects lists to be comma separated. A trailing comma must also be avoided. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 59914 [details] [review] Bug 18044: Add a test Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05, thanks Chris, Jonathan!
These patches have been pushed to 16.11.x and will be in 16.11.04.
Pushed to 3.22.x for 3.22.17
Pushed to 16.05.x, for 16.05.10 release
Thanks to everyone who helped get this resolved quickly!