Created attachment 60001 [details] [review] Bug 18077: Batch item modification link is bold when batch item deletion is active in tools menu To test: 1) Go to Tools -> Batch item deletion 2) Notice the link for Batch item MODIFICATION is bold, not the deletion link 3) Apply patch and refresh page 4) Correct link should now be bold. 5) Go to batch item modification and confirm the correct link is bold Sponsored-by: Catalyst IT
Created attachment 60107 [details] [review] Bug 18077: Batch item modification link is bold when batch item deletion is active in tools menu To test: 1) Go to Tools -> Batch item deletion 2) Notice the link for Batch item MODIFICATION is bold, not the deletion link 3) Apply patch and refresh page 4) Correct link should now be bold. 5) Go to batch item modification and confirm the correct link is bold Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Aleisha, I would suggest to match for something more specific than "del", which does not sounds very robust. We could search for the script's name and "del".
Created attachment 60221 [details] [review] Bug 18077: Batch item modification link is bold when batch item deletion is active in tools menu To test: 1) Go to Tools -> Batch item deletion 2) Notice the link for Batch item MODIFICATION is bold, not the deletion link 3) Apply patch and refresh page 4) Correct link should now be bold. 5) Go to batch item modification and confirm the correct link is bold Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 60247 [details] [review] Bug 18077: Batch item modification link is bold when batch item deletion is active in tools menu To test: 1) Go to Tools -> Batch item deletion 2) Notice the link for Batch item MODIFICATION is bold, not the deletion link 3) Apply patch and refresh page 4) Correct link should now be bold. 5) Go to batch item modification and confirm the correct link is bold Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 60468 [details] [review] Bug 18077: Batch item modification link is bold when batch item deletion is active in tools menu To test: 1) Go to Tools -> Batch item deletion 2) Notice the link for Batch item MODIFICATION is bold, not the deletion link 3) Apply patch and refresh page 4) Correct link should now be bold. 5) Go to batch item modification and confirm the correct link is bold Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Aleisha!
This won't get ported back to 16.11.x as it is an enhancement.