Bug 18078 - Updating buttons for z39.50 Authority search
Summary: Updating buttons for z39.50 Authority search
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Z39.50 / SRU / OpenSearch Servers (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 02:21 UTC by Aleisha Amohia
Modified: 2023-09-10 12:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18078: Updating buttons for z39.50 Authority search (4.16 KB, patch)
2017-02-08 02:23 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18078: Updating buttons for z39.50 Authority search (4.40 KB, patch)
2017-03-16 14:28 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 18078: Updating buttons for z39.50 Authority search (4.80 KB, patch)
2018-12-07 17:37 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2017-02-08 02:21:58 UTC

    
Comment 1 Aleisha Amohia 2017-02-08 02:23:35 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2017-03-16 14:28:42 UTC
Created attachment 61172 [details] [review]
Bug 18078: Updating buttons for z39.50 Authority search

1) Go to Home > Authorities -> New from Z39.50
2) Notice how Search button is strangely off page (have to scroll down
    to see it)
3) Do a search, noticing the ugly buttons from Comment 1
4) Apply patch and go back to a new search
5) Do a search again, notice no longer need to scroll to get to Search
button and new, nicer buttons
6) Confirm they still work as expected

Sponsored-by: Catalyst IT

Testplan changed to test with Authorities. Z39.50 search for authorities
displays and Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jonathan Druart 2017-03-17 13:19:54 UTC
I discussed with Owen about the use of btn-primary and I think the conclusion was not to use as it is, but customise our own.
I do not find the bug report where it has been discussed, so ccing Owen to refresh my mind.
Comment 4 Marc Véron 2017-03-17 13:45:51 UTC
(In reply to Jonathan Druart from comment #3)
> I discussed with Owen about the use of btn-primary and I think the
> conclusion was not to use as it is, but customise our own.
> I do not find the bug report where it has been discussed, so ccing Owen to
> refresh my mind.

Maybe Bug 18042 ?
Comment 5 Jonathan Druart 2017-03-17 14:05:39 UTC
Yes certainly, thanks!
Comment 6 julien.comte 2017-03-22 11:39:12 UTC
No need to scroll to get to search buttons.
Comment 7 Jonathan Druart 2017-03-29 19:14:15 UTC
From bug 18042 comment 5:
"- I think we should come up with updates to the default Bootstrap button styles if we are going to use more than the btn-default class. Bootstrap colors aren't designed to work with Koha's, and we should avoid looking like out-of-the-box Bootstrap."
Comment 8 Owen Leonard 2018-12-07 17:37:09 UTC Comment hidden (obsolete)
Comment 9 Aleisha Amohia 2018-12-09 20:46:33 UTC Comment hidden (obsolete)
Comment 10 Owen Leonard 2019-01-04 14:35:30 UTC
(In reply to Aleisha Amohia from comment #9)
> Wasn't able to complete the Search. After clicking Search, this error shows:
> 
> Template process failed: undef error - WHILE loop terminated (> 1000
> iterations)
>  at /home/vagrant/kohaclone/C4/Templates.pm line 122

I'm obsoleting that comment because it's really long and I think the above snippet is what's really relevant: My changed template tries to use a WHILE loop with result pages and there is a hard limit of 1000 for that kind of loop.
Comment 11 Owen Leonard 2019-05-16 18:12:31 UTC
My patch is a non-starter, so I restored Aleisha's.
Comment 12 Katrin Fischer 2023-09-10 12:24:24 UTC
These buttons have also seen some updates with the staff interface redesign. It's a bit hard without a screenshot or similar, but I think main goals have been achieved.