Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear.
Created attachment 60055 [details] [review] Bug 18089 - Unit test
Created attachment 60056 [details] [review] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. Test Plan: 1) Apply this patch set 2) prove t/XSLT.t
Created attachment 60061 [details] [review] [SIGNED-OFF] Bug 18089 - Unit test Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 60062 [details] [review] [SIGNED-OFF] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. Test Plan: 1) Apply this patch set 2) prove t/XSLT.t Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 60065 [details] [review] Bug 18089 - Unit test Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 60066 [details] [review] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. Test Plan: 1) Apply this patch set 2) prove t/XSLT.t Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 60067 [details] [review] Bug 18089: Remove warnings from tests using DBIx::Class fixtures Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05, thanks Jonathan!
These patches have been pushed to 16.11.x and will be in 16.11.04.
Pushed to 16.05.x, for 16.05.10 release