If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)."
Created attachment 60119 [details] [review] Bug 18095: Batch item modification: Better message if no item is modified If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)." To test: - Apply patch - Repeat steps above - Verify that message makes sense.
Created attachment 60128 [details] [review] Bug 18095: Batch item modification: Better message if no item is modified If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)." To test: - Apply patch - Repeat steps above - Verify that message makes sense. NOTE: Also tested positive case with actual field change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 60178 [details] [review] Bug 18095: Batch item modification: Better message if no item is modified If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)." To test: - Apply patch - Repeat steps above - Verify that message makes sense. NOTE: Also tested positive case with actual field change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05, thanks Marc!
This patch has been pushed to 16.11.x and will be in 16.11.04.
Pushed to 16.05.x, for 16.05.10 release