At the moment, batch deletion for biblios does not let you submit the deletion form without selecting a checkbox - an alert pops up. This behaviour is not the same for authorities. If nothing is selected, the form still submits and says the deletion was successful.
Created attachment 60370 [details] [review] Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT
Eyeballs well. It's a cut-and-paste tweak of the same code for Biblios.
Created attachment 60591 [details] [review] Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 60620 [details] [review] Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Aleisha!
'Upping' this to be a bug fix as this fixes the former inconsistent behaviour. This patch has been pushed to 16.11.x and will be in 16.11.05.