The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable.
Created attachment 60817 [details] [review] Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable.
Created attachment 60873 [details] [review] Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc Véron <veron@veron.ch>
Philippe, This is done differently in labels/label-manage.tt We should stay consistent and use the same way to make these strings translatable in both template files.
Created attachment 60935 [details] [review] Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 60936 [details] [review] Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc Véron <veron@veron.ch> Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 60953 [details] [review] Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc Véron <veron@veron.ch> Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 60954 [details] [review] Bug 18209: Add default, 'Actions' and fix case Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Phillipe, Jonathan!
These patches have been pushed to 16.11.x and will be in 16.11.07.
Pushed to 3.22.x for 3.22.20
Pushed to 16.05.x, for 16.05.12 release