Created attachment 61224 [details] [review] Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio.
Created attachment 61226 [details] [review] Bug 18296: C4::Items - Remove GetItemInfosOf At this point this subroutine is only used once, from reserve/request.pl. Since we already have the items, it's easy to populate the different hashes as the rest of the code is expecting it. Test plan: You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked
Created attachment 63888 [details] [review] [SIGNED-OFF] Bug 18296: C4::Items - Remove GetItemInfosOf At this point this subroutine is only used once, from reserve/request.pl. Since we already have the items, it's easy to populate the different hashes as the rest of the code is expecting it. Test plan: You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Cannot apply this on top of 18295. Regardless of applying 18279 in between or not.
Created attachment 63944 [details] [review] Bug 18296: C4::Items - Remove GetItemInfosOf At this point this subroutine is only used once, from reserve/request.pl. Since we already have the items, it's easy to populate the different hashes as the rest of the code is expecting it. Test plan: You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
(In reply to Marcel de Rooy from comment #4) > Cannot apply this on top of 18295. > Regardless of applying 18279 in between or not. It applied ok for me, reattached anyway 1c01bbb112 Bug 18296: C4::Items - Remove GetItemInfosOf 81caf630f1 Bug 18295: C4::Items - get_itemnumbers_of 5d94ff7513 DBRev 17.05.00.000
(In reply to Jonathan Druart from comment #6) > (In reply to Marcel de Rooy from comment #4) > > Cannot apply this on top of 18295. > > Regardless of applying 18279 in between or not. > > It applied ok for me, reattached anyway > > 1c01bbb112 Bug 18296: C4::Items - Remove GetItemInfosOf > 81caf630f1 Bug 18295: C4::Items - get_itemnumbers_of > 5d94ff7513 DBRev 17.05.00.000 Current master now: Applying: Bug 18296: C4::Items - Remove GetItemInfosOf fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge.
Created attachment 64050 [details] [review] Bug 18296: C4::Items - Remove GetItemInfosOf At this point this subroutine is only used once, from reserve/request.pl. Since we already have the items, it's easy to populate the different hashes as the rest of the code is expecting it. Test plan: You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
It applies now! Thanks.
Created attachment 64073 [details] [review] Bug 18296: C4::Items - Remove GetItemInfosOf At this point this subroutine is only used once, from reserve/request.pl. Since we already have the items, it's easy to populate the different hashes as the rest of the code is expecting it. Test plan: You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Created attachment 64106 [details] [review] Bug 18296: Remove perlcritic error (request.pl) "$itemnumbers_of_biblioitem" is declared but not used at line 314, column 5. Unused variables clutter code and make it harder to read. (Severity: 3)
Last patch pushed to master!
*** Bug 18753 has been marked as a duplicate of this bug. ***
Enhancement not pushed to 17.05.x