Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list).
Created attachment 61285 [details] [review] Bug 18304: Do not mail cart or list contents to the library Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). This patch simply puts a note on both forms saying that they should not use the mail to request or renew books. If both options are disabled on the OPAC, the message is not shown. Test plan: [1] Enable RequestOnOPAC. [2] Put a book in the cart. [3] Open the cart, click on Send. Verify presence of the message. [4] Open a list. [5] Click on Send list. Verify presence of the message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 61317 [details] [review] Bug 18304: Do not mail cart or list contents to the library Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). This patch simply puts a note on both forms saying that they should not use the mail to request or renew books. If both options are disabled on the OPAC, the message is not shown. Test plan: [1] Enable RequestOnOPAC. [2] Put a book in the cart. [3] Open the cart, click on Send. Verify presence of the message. [4] Open a list. [5] Click on Send list. Verify presence of the message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 61339 [details] [review] Bug 18304: Do not mail cart or list contents to the library Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). This patch simply puts a note on both forms saying that they should not use the mail to request or renew books. If both options are disabled on the OPAC, the message is not shown. Test plan: [1] Enable RequestOnOPAC. [2] Put a book in the cart. [3] Open the cart, click on Send. Verify presence of the message. [4] Open a list. [5] Click on Send list. Verify presence of the message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Can we please add an id/class to this? We have at least one library who pulls the books from the shelves using the cart and doesn't allow on-shelf-holds. This would allow us to change/hide the note using CSS.
Created attachment 61346 [details] [review] Bug 18304: [QA Follow-up] Add id to paragraph tag See Bugzilla, comment 4. Note: the id is unique in the Koha codebase (git grepped). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thank you, Marcel!
Pushed to master for 17.05, thanks Marcel!
This won't get ported back to 16.11.x as it is an enhancement.