When on-site checkouts are 'Unlimited' the checkouts can be blocked if there is a limit for checkouts in general To reproduce: Set All/All rule with Unlimited/unlimited for normal/onsite checkouts Will be able to perform onsite checkout Edit rule to be 15/Unlimited normal/onsite Will get error 'Too many: 1 on site checkout, only are allowed' Set rule to 15/15 Onsite checkouts work again Similar issue with Default checkout, hold and return policy and Default checkout limit by patron category
Added Bug 18321 as related (problems with checkout count with onsite related sysprefs)
What wording do you suggest?
I don't think the wording is the problem, it is the implementation - instead of being 'unlimited' the rules are applying as 0
Created attachment 68896 [details] [review] Bug 18357: Handle unlimited on-site checkouts If on-site checkouts are set to unlimited (i.e. NULL/undef), they are currently blocked. Test plan: 1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts 2/ Will be able to perform onsite checkout 3/ Edit rule to be 15/Unlimited normal/onsite 4/ Will be able to perform onsite checkout => Without this patch it was blocked 5/ Set rule to 15/15 6/ Onsite checkouts work again
Created attachment 68930 [details] [review] Bug 18357: Handle unlimited on-site checkouts If on-site checkouts are set to unlimited (i.e. NULL/undef), they are currently blocked. Test plan: 1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts 2/ Will be able to perform onsite checkout 3/ Edit rule to be 15/Unlimited normal/onsite 4/ Will be able to perform onsite checkout => Without this patch it was blocked 5/ Set rule to 15/15 6/ Onsite checkouts work again Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 69129 [details] [review] Bug 18357: Handle unlimited on-site checkouts If on-site checkouts are set to unlimited (i.e. NULL/undef), they are currently blocked. Test plan: 1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts 2/ Will be able to perform onsite checkout 3/ Edit rule to be 15/Unlimited normal/onsite 4/ Will be able to perform onsite checkout => Without this patch it was blocked 5/ Set rule to 15/15 6/ Onsite checkouts work again Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!