Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make.
Created attachment 61798 [details] [review] Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade`
Created attachment 61799 [details] [review] Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade`
Created attachment 61840 [details] [review] [SIGNED-OFF] Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Can we get speedy QA on this please? The bug is present in 16.11.06.
(In reply to Katrin Fischer from comment #4) > Can we get speedy QA on this please? The bug is present in 16.11.06. Upping severity
Just bumped into this, so +1 for a speedy QA...
Created attachment 62165 [details] [review] Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05, thanks Jonathan!
This patch has been pushed to 16.11.x and will be in 16.11.07.
Pushed to 16.05.x, for 16.05.12 release