Created attachment 61929 [details] report settings The canned report under Home › Reports › Acquisitions statistics is not filtering on collection code. To replicate: 'Received on' check 'row' Filter: From: 01/01/2016 To: 12/31/2016 (or use a date range that corresponds to acquisitions on your system) 'Collection code' check 'column' Filter: Select 'All' Cell value Choose 'Count items' Output Choose 'To screen into the browser' Click Submit. You will see columns of collection codes, with each row being a separate date. All collection codes will be displayed. Use the browser's back button, change the collection code 'Collection code' check 'column' Filter: Select 'Music' (or a collection code on your system) Click submit. We would expect to see a single column showing the 'Music' collection code -- instead we see all collection codes again. See screenshots for report settings and output.
Created attachment 61930 [details] Report results, all collection codes
Created attachment 61931 [details] Report results, choose collection code 'music only'
It looks like a template issue, the codes in the values are missing: <select name="Filter"> <option value="" selected="selected">All</option> <option value="">Fiction</option> <option value="">Non-fiction</option> <option value="">Reference</option>
Created attachment 84948 [details] [review] Bug 18939: Acquisition statistics - Fix wrong template variable name for collection filter The template variable was wrong, so the filter never submitted the collection code for the query. Before: <option value="">Fiction</option> <option value="">Non-fiction</option> After: <option value="FIC">Fiction</option> <option value="NFIC">Non-fiction</option> To test: - Go to Reports > Statistics wizards > Acquisitions - Pick a row and column - Compare results with and without collection filter - Verify the table is always the same - Apply patch - Repeat comparison, verify the filter works now
Created attachment 85023 [details] [review] Bug 18939: Acquisition statistics - Fix wrong template variable name for collection filter The template variable was wrong, so the filter never submitted the collection code for the query. Before: <option value="">Fiction</option> <option value="">Non-fiction</option> After: <option value="FIC">Fiction</option> <option value="NFIC">Non-fiction</option> To test: - Go to Reports > Statistics wizards > Acquisitions - Pick a row and column - Compare results with and without collection filter - Verify the table is always the same - Apply patch - Repeat comparison, verify the filter works now https://bugs.koha-community.org/show_bug.cgi?id=18393 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice work Katrin, another great fix that I'm going to go straight for PQA on.. works well, no regressions found.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04 - I corrected the commit message to state the correct bug number on push too.. 18939 -> 18393
backported to 18.05.x for 18.05.11