There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong
Created attachment 61939 [details] [review] Bug 18395: (bug 14601 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green
Created attachment 61943 [details] [review] Bug 18395: (bug 14601 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 61960 [details] [review] Bug 18395: (bug 14610 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05, thanks Jonathan!
Doesn't apply cleanly to 16.11.x - will skip this.