Created attachment 62057 [details] [review] Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) To test: 1 - Apply patch 2 - Open advanced cataloging editor 3 - Try using Alt+P and Alt+C and note symbols are added 4 - Save record and ensure symbols are saved
I think it would be nice to have these shortcuts documented under the "Keyboard shortcuts" button in editor toolbar, what do you think?
This works nicely, but needs documentation. Maybe add it to the shortcut list?
Created attachment 68501 [details] [review] Bug 18417: Followup - Document new shortcuts in dropdown
Sweet little patch. Works great. Nice display of what the ALT+C and ALT+P do. I attempted it on a random MARC subfield (028$b), and it saved and retrieved the changes just fine. Signing off.
Created attachment 68509 [details] [review] Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) To test: 1 - Apply patch 2 - Open advanced cataloging editor 3 - Try using Alt+P and Alt+C and note symbols are added 4 - Save record and ensure symbols are saved Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 68510 [details] [review] Bug 18417: Followup - Document new shortcuts in dropdown Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 70237 [details] [review] Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) To test: 1 - Apply patch 2 - Open advanced cataloging editor 3 - Try using Alt+P and Alt+C and note symbols are added 4 - Save record and ensure symbols are saved Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70238 [details] [review] Bug 18417: (follow-up) Document new shortcuts in dropdown Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.02
Pushed to 17.05.x for v17.05.09