We are seeing on some sites that the 'Add child' button is not appearing on moremember.pl In these cases it seems the line: activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''), Fails to pass through the correct value
Created attachment 62094 [details] [review] Bug 18423 - Add child button not always appearing - problem in template variable This patch removes the retrieval of the syspref borrowerRelationship from the scripts and moves it to a check using the Template Toolkit plugin To test: 1 - Apply patch 2 - Ensure 'Add child' button displays appropriately on all member pages.
Created attachment 62100 [details] [review] Bug 18423 - Add child button not always appearing - problem in template variable This patch removes the retrieval of the syspref borrowerRelationship from the scripts and moves it to a check using the Template Toolkit plugin To test: 1 - Apply patch 2 - Ensure 'Add child' button displays appropriately on all member pages.
Created attachment 62101 [details] [review] Bug 18423 follow up - fix display off add child on members/notices.pl
Hi Nick I have tested your patches following your test plan. The 'Add child' button does not appears on the following tab pages in the moremember.pl with your patches attached: * details * routing lists * Notices * Statistics You say in your test plan '2 - Ensure 'Add child' button displays appropriately on all member pages.' so I am assuming the 'Add child' button is supposed to be being displayed on the above member pages and so these patches are not meeting the test plan Regards Alex
Created attachment 62225 [details] [review] Bug 18423 Follow-up - Add 'Add child' button to statistics tab
Please retest, I added a patch to add the button to 'Statistics' tabs, all other are displaying for me. The only tab I don't see the button on is 'Modification log' as it does not include the tool bar.
Created attachment 62228 [details] [review] Bug 18423 - Add child button not always appearing - problem in template variable This patch removes the retrieval of the syspref borrowerRelationship from the scripts and moves it to a check using the Template Toolkit plugin To test: 1 - Apply patch 2 - Ensure 'Add child' button displays appropriately on all member pages. Tested 3 pateches together, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 62229 [details] [review] Bug 18423 follow up - fix display off add child on members/notices.pl Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 62230 [details] [review] Bug 18423 Follow-up - Add 'Add child' button to statistics tab Signed-off-by: Marc Véron <veron@veron.ch>
Still 3 others: - members/deletemem.pl - members/files.pl - members/housebound.pl Noticed something weird: moremember.pl is the only template passing ( $template->param( adultborrower => 1 ) ) if ( $category_type eq 'A' || $category_type eq 'I' ); others only pass $category_type eq 'A'. It comes from bug 5112. Katrin, could you clarify please?
Created attachment 62307 [details] [review] Bug 18423 - Add 'Add child' button to files, housebound, and deletemem pages
Created attachment 62308 [details] [review] Bug 18423 - Followup - enable Add child button for institutional borrowers If they can have guarantors and we shwo the button on one page I think we should in fact show it on all.
Created attachment 62312 [details] [review] Bug 18423 - Add child button not always appearing - problem in template variable This patch removes the retrieval of the syspref borrowerRelationship from the scripts and moves it to a check using the Template Toolkit plugin To test: 1 - Apply patch 2 - Ensure 'Add child' button displays appropriately on all member pages. Tested 3 pateches together, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 62313 [details] [review] Bug 18423 follow up - fix display off add child on members/notices.pl Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 62314 [details] [review] Bug 18423 Follow-up - Add 'Add child' button to statistics tab Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 62315 [details] [review] Bug 18423 - Add 'Add child' button to files, housebound, and deletemem pages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 62316 [details] [review] Bug 18423 - Followup - enable Add child button for institutional borrowers If they can have guarantors and we shwo the button on one page I think we should in fact show it on all. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Nick!
It's all about buttons, but doe appear to be safe string wise. These patches have been pushed to 16.11.x and will be in 16.11.07.
Pushed to 16.05.x, for 16.05.12 release
Pushed to 3.22.x for 3.22.21