System preference TalkingTechItivaPhoneNotification is missing from sysprefs.sql.
Created attachment 62273 [details] [review] Bug 18444: Add TalkingTechItivaPhoneNotification to sysprefs.sql
Created a test to spot all of these. Bug 18446
Created attachment 62917 [details] [review] Bug 18444: Add TalkingTechItivaPhoneNotification to sysprefs.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I wonder if we should also have an atomicupdate checking if the preference already exists and adding it if not.
Created attachment 63400 [details] [review] Bug 18444: Add TalkingTechItivaPhoneNotification to sysprefs.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05, thanks Lari!
This patch has been pushed to 16.11.x and will be in 16.11.08.
This causes tests to fail on Jenkins: https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastBuild/testReport/junit/(root)/t_db_dependent_check_sysprefs_t/Syspref_TalkingTechItivaPhoneNotification_exists_in_the_database__356_/ I think we should have a database update too, checking for its existence and inserting it in the database if it's not there already.
Pushed to 3.22.x for 3.22.21
Pushed to 16.05.x, for 16.05.13 release