When suspending all holds from the staff client on a patrons account until a specified date, the holds suspend indefinitely rather than by a specific date. The behavior works as expected for suspending a hold when selecting one item at a time. However suspending all holds by a specific date does not trigger a specified date.
Created attachment 62526 [details] [review] Bug 18469 - Suspend all holds when specifying a date to resume hold does not keep date Name of field had 'datepicker' embedded, this caused variable issue To test: 1 - Place several holds for a patron 2 - Go to holds tab in circulation 3 - Select a date for suspend all holds until 4 - Suspend all holds 5 - Note date is not used, suspended indefinitely 6 - Apply patch 7 - Resume all suspended holds 8 - Select a date for suspend all holds until 9 - Suspend all holds 10 - Note date is used
Created attachment 62612 [details] [review] [SIGNED-OFF] Bug 18469 - Suspend all holds when specifying a date to resume hold does not keep date Name of field had 'datepicker' embedded, this caused variable issue To test: 1 - Place several holds for a patron 2 - Go to holds tab in circulation 3 - Select a date for suspend all holds until 4 - Suspend all holds 5 - Note date is not used, suspended indefinitely 6 - Apply patch 7 - Resume all suspended holds 8 - Select a date for suspend all holds until 9 - Suspend all holds 10 - Note date is used Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Nick it seems that we have the same issue on moremember, but the feature is not displayed because SuspendHoldsIntranet and or AutoResumeSuspendedHolds is not passed (should use Koha.Preference instead). I am also wondering if we should not re-add the datepicker class name.
Created attachment 64906 [details] [review] Bug 18469 - (QA Followup) Restore datepicker class Use Koha.Preference Copy changes ot moremember
Created attachment 65508 [details] [review] Bug 18469: Suspend all holds when specifying a date to resume hold does not keep date Name of field had 'datepicker' embedded, this caused variable issue To test: 1 - Place several holds for a patron 2 - Go to holds tab in circulation 3 - Select a date for suspend all holds until 4 - Suspend all holds 5 - Note date is not used, suspended indefinitely 6 - Apply patch 7 - Resume all suspended holds 8 - Select a date for suspend all holds until 9 - Suspend all holds 10 - Note date is used Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 65509 [details] [review] Bug 18469: QA Follow-up Restore datepicker class Use Koha.Preference Copy changes to moremember Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
These patches have been pushed to 16.11.x and will be in 16.11.13.
Pushed to 16.05.x, for 16.05.18 release